Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoprefixer support #472

Merged
merged 4 commits into from Aug 27, 2014
Merged

Conversation

mente
Copy link
Contributor

@mente mente commented Jul 20, 2013

Hello,

This PR adds support of great lib autoprefixer that helps to solve down vendor-specific nightmare in css. I know there are mixins, but not everyone uses sass, less or other css compilers.

Looking forward for comments.

@ai
Copy link

ai commented Aug 8, 2013

CSS Tricks publish good article, why Autoprefixer is cool and how it works: http://css-tricks.com/autoprefixer/

@mente mente mentioned this pull request Aug 8, 2013
/**
* @param string $browser
*/
public function setBrowsers($browser)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find it more logical to configure the browsers as an array in PHP and build the comma separated string only when calling the binary.

Note that when calling autoprefixer programmatically in JS, browsers are also passed as an array

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it would be more clear

@mente
Copy link
Contributor Author

mente commented Aug 8, 2013

Should I squash commits into 1?

@ai
Copy link

ai commented Aug 8, 2013

What How To I should post on Autoprefixer README.md?

@mente
Copy link
Contributor Author

mente commented Aug 8, 2013

@ai i'll provide PR to your repo. Also there will be PR for Symfony2 Bundle after this PR is merged. Hopefully soon enough :)

@guill3m
Copy link

guill3m commented Jan 14, 2014

What's the status on this PR?

Is it planned to be merged to core or should we use it as a custom filter?

Thank you.

@patchampoux
Copy link

Please merge this?

Thank you.

kriswallsmith added a commit that referenced this pull request Aug 27, 2014
@kriswallsmith kriswallsmith merged commit 7c9639d into kriswallsmith:master Aug 27, 2014
@kriswallsmith
Copy link
Owner

Thank you!

@mente
Copy link
Contributor Author

mente commented Aug 27, 2014

Awesome, thanks!

@stof
Copy link
Collaborator

stof commented Aug 27, 2014

tests are broken on Travis

@mente
Copy link
Contributor Author

mente commented Aug 27, 2014

PR was made more than year ago, might be outdated. Checking it

@ai
Copy link

ai commented Aug 27, 2014

Autoprefixer was rewritten several times since this PR ;).

mente added a commit to mente/assetic that referenced this pull request Aug 27, 2014
stof added a commit that referenced this pull request Sep 16, 2014
fixed autoprefixer unit tests problem introduced in #472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants