New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoprefixer support #472
autoprefixer support #472
Conversation
CSS Tricks publish good article, why Autoprefixer is cool and how it works: http://css-tricks.com/autoprefixer/ |
/** | ||
* @param string $browser | ||
*/ | ||
public function setBrowsers($browser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would find it more logical to configure the browsers as an array in PHP and build the comma separated string only when calling the binary.
Note that when calling autoprefixer programmatically in JS, browsers are also passed as an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it would be more clear
Should I squash commits into 1? |
What How To I should post on Autoprefixer README.md? |
@ai i'll provide PR to your repo. Also there will be PR for Symfony2 Bundle after this PR is merged. Hopefully soon enough :) |
What's the status on this PR? Is it planned to be merged to core or should we use it as a custom filter? Thank you. |
Please merge this? Thank you. |
Thank you! |
Awesome, thanks! |
tests are broken on Travis |
PR was made more than year ago, might be outdated. Checking it |
Autoprefixer was rewritten several times since this PR ;). |
fixed autoprefixer unit tests problem introduced in #472
Hello,
This PR adds support of great lib autoprefixer that helps to solve down vendor-specific nightmare in css. I know there are mixins, but not everyone uses sass, less or other css compilers.
Looking forward for comments.